Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor phone context parsing and phone number normalizing logic. #3790

Open
wants to merge 3 commits into
base: refactor-regex-consts-cpp
Choose a base branch
from
Open

Refactor phone context parsing and phone number normalizing logic. #3790

wants to merge 3 commits into from

Conversation

silvio2402
Copy link
Collaborator

This is part 2 of the refactoring related to b/370922064.

  • Refactor logic for parsing the phone-context parameter to phonecontextparser.cc.
  • Refactor NormalizeDigitsOnly method to phonenumbernormalizer.cc. Note that this keeps the original method as a shell since it's public.

@silvio2402 silvio2402 requested a review from tvislavski January 22, 2025 16:30
@silvio2402 silvio2402 requested a review from a team as a code owner January 22, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvislavski tvislavski Awaiting requested review from tvislavski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@silvio2402