feat: change gain scale from linear to exponential

google · Feb 5, 2024 · 1baaced · 1baaced
1 parent cf48e5d
commit 1baaced
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/image_user_layer.ts b/src/image_user_layer.ts
@@ -466,7 +466,7 @@ const LAYER_CONTROLS: LayerControlDefinition<ImageUserLayer>[] = [
     isValid: (layer) => layer.volumeRendering,
     ...rangeLayerControl((layer) => ({
       value: layer.volumeRenderingGain,
-      options: { min: 0.01, max: 16.0, step: 0.01 },
+      options: { min: -10.0, max: 10.0, step: 0.1 },
     })),
   },
   {

diff --git a/src/volume_rendering/volume_render_layer.ts b/src/volume_rendering/volume_render_layer.ts
@@ -645,7 +645,7 @@ void main() {
         const farLimitFraction = (adjustedFar - near) / (far - near);
         gl.uniform1f(shader.uniform("uNearLimitFraction"), nearLimitFraction);
         gl.uniform1f(shader.uniform("uFarLimitFraction"), farLimitFraction);
-        gl.uniform1f(shader.uniform("uGain"), this.gain.value);
+        gl.uniform1f(shader.uniform("uGain"), Math.exp(this.gain.value));
         gl.uniform1i(
           shader.uniform("uMaxSteps"),
           this.depthSamplesTarget.value,