Fix Logging and Error Handling for get_benchmark_final_target_code #910
+37
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@Kartikayy007 for visibility. |
|
Experiment launched in #919 |
This was referenced Mar 23, 2025
Closed
DonggeLiu
pushed a commit
that referenced
this pull request
Mar 24, 2025
) ## Description This PR addresses the issue of missing source code by adding enhanced logging and improving error handling in the `get_benchmark_final_target_code()` method. Previously, silent failures could occur, making it difficult to diagnose the root cause of missing source code. ## Changes - **Enhanced Logging**: Logs are added to track when the `sample_id` is invalid or the source code is missing. - **Error Handling**: Ensures that malformed or empty `sample_id` values are handled gracefully and logged appropriately. - **Return Null for Missing Source Code**: In case of an error, the function explicitly returns `None` rather than an empty string for clarity in JSON outputs. #908 It may also refer to #625 ## Benefits - Improved **debuggability** by making it easier to identify the reasons behind missing source code. - Increased **robustness** by preventing silent failures and ensuring more informative logs and error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of missing source code by adding enhanced logging and improving error handling in the
get_benchmark_final_target_code()method. Previously, silent failures could occur, making it difficult to diagnose the root cause of missing source code.Changes
sample_idis invalid or the source code is missing.sample_idvalues are handled gracefully and logged appropriately.Nonerather than an empty string for clarity in JSON outputs.Add Logging and Error Handling for get_benchmark_final_target_code #908
It may also refer to missing error logs for failed build #625
Benefits