Move and rename map node ID type #2525
Merged
+351
−350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's better to review #2526 first. This PR will become much simpler after rebasing. |
This introduces a circular dependency smt->maphasher->smt, and a similar one with coniks.
|
@pphaneuf This is ready for review now. It's a big but simple one: in a nutshell, just a move + rename + update usages. |
|
@mhutchinson PTAL too, it affects |
mhutchinson
approved these changes
Jun 8, 2021
pav-kv
force-pushed
the
move_node_id2
branch
2 times, most recently
from
e077da7 to
433278c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node ID type logically belongs to the
merklesubfolder which holds the algorithmicaspect of Merkle trees. This change moves the
NodeID2type, which is now known simplyas
node.ID. It also untangles some dependencies that blocked this change.#1855
#2378