Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubtreeCache: Switch to regular maps #2594

Merged
merged 1 commit into from
Jul 28, 2021
Merged

SubtreeCache: Switch to regular maps #2594

merged 1 commit into from
Jul 28, 2021

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Jul 27, 2021 •
edited
Loading

The application-level logic calls GetMerkleNodes and SetMerkleNodes at
most once, and never does it concurrently. Correspondingly, the GetNodes
and SetNodes methods of SubtreeCache don't need to be thread-safe.

The thread safety of SubtreeCache was introduced for the Map needs, but
the Map mode has been deleted for now.

This change simplifies SubtreeCache so that it doesn't expect parallel calls.

#2378

@google-cla google-cla bot added the cla: yes label Jul 27, 2021
@pav-kv pav-kv marked this pull request as ready for review July 27, 2021 11:45
@pav-kv pav-kv requested a review from a team as a code owner July 27, 2021 11:45
@pav-kv pav-kv force-pushed the use_regular_map branch from 294d8ab to 89b7d9a Compare July 27, 2021 14:34
@pav-kv pav-kv merged commit 1cf6d3b into google:master Jul 28, 2021
@pav-kv pav-kv deleted the use_regular_map branch July 28, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

@Martin2112 Martin2112 Awaiting requested review from Martin2112

@pphaneuf pphaneuf Awaiting requested review from pphaneuf

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pav-kv @AlCutter