fix(logging): Propagate better errors and prevent infinite retry with invalid UTF-8 chars #7509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #3629 .
Invalid UTF-8 characters currently cause deadline exceeded errors after repeated retries [2] against an Internal error which happen when marshaling a message [1] . This makes application code stuck and eventually discard logs.
This change applies the same fix as #5728 to the logging library.
The reproduction steps are described at:
#3629 (comment)
[1]
[2]