feat: add enforce linkage checker #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 74.87% 74.87%
Complexity 97 97
=========================================
Files 11 11
Lines 589 589
Branches 1 1
=========================================
Hits 441 441
Misses 147 147
Partials 1 1Continue to review full report at Codecov.
|
elharo
reviewed
Jan 7, 2020
chingor13
reviewed
Jan 7, 2020
Comment on lines
+181
to
+204
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-enforcer-plugin</artifactId> | ||
| <version>3.0.0-M3</version> | ||
| <executions> | ||
| <execution> | ||
| <id>enforce</id> | ||
| <goals> | ||
| <goal>enforce</goal> | ||
| </goals> | ||
| <configuration> | ||
| <rules> | ||
| <requireMavenVersion> | ||
| <version>[3.0,)</version> | ||
| </requireMavenVersion> | ||
| <requireJavaVersion> | ||
| <version>[1.7,)</version> | ||
| </requireJavaVersion> | ||
| <requireUpperBoundDeps/> | ||
| </rules> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
We already include this check in the shared-config parent project
There was a problem hiding this comment.
thanks,for the info. so can we add one more rule over there for linkage checker?
<LinkageCheckerRule implementation="com.google.cloud.tools.dependencies.enforcer.LinkageCheckerRule">
<reportOnlyReachable>true</reportOnlyReachable>
</LinkageCheckerRule>
There was a problem hiding this comment.
I don't think you want <reportOnlyReachable>true</reportOnlyReachable> here.
elharo
approved these changes
Jan 7, 2020
|
This enforcer config is already present in the shared-config since at least version 0.3.0 as can be seen here |
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
* Add the three examples from google-cloud-examples * Update example links to be internal * fix: skip clirr for examples artifact Co-authored-by: Jeff Ching <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6396