-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spanner Implementation for Vector Store #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Static Utility to create a table to store vector embeddings - Automatic Dialect Detection for GSQL and PG - Similarity Search & Maximal Marginal Relevance Search - Add documents and texts
…tion & also while creating new table through static utility.
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/langchain-google-spanner-python API.
label
Feb 13, 2024
…ad_timestamp and min and exact staleness.
averikitsch
requested changes
Feb 14, 2024
averikitsch
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will tests also be provided in this PR?
averikitsch
reviewed
Feb 20, 2024
rahul2393
approved these changes
Feb 21, 2024
averikitsch
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the error messages using "id-{" before merging.
* test: Adding integration tests for static utility to create vector embeddings table. * test: Adding add,search,delete integration tests for VectorStore. * test: lint * test: lint * style: lint * style: lint * Empty-Commit to trigger tests * test: addressing review comments. * test: test fix * adding bs4 in test dependencies --------- Co-authored-by: Averi Kitsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanner Implementation for Vector Stores, supports: