Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spanner Implementation for Vector Store #10

Merged
merged 23 commits into from
Feb 22, 2024

Conversation

gauravpurohit06
Copy link
Contributor

Spanner Implementation for Vector Stores, supports:

  1. Search: (Exact Neighbors Search/ KNN, search with maximum marginal relevance)
  2. Initialization: (Existing table, also supports creation of new table)
  3. Add and Delete Vector documents/embeddings.

- Static Utility to create a table to store vector embeddings
- Automatic Dialect Detection for GSQL and PG
- Similarity Search & Maximal Marginal Relevance Search
- Add documents and texts
…tion & also while creating new table through static utility.
@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner February 13, 2024 06:28
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label Feb 13, 2024
src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
@averikitsch averikitsch removed their assignment Feb 14, 2024
Copy link
Collaborator

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will tests also be provided in this PR?

src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Show resolved Hide resolved
Copy link
Collaborator

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the error messages using "id-{" before merging.

src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
src/langchain_google_spanner/vector_store.py Outdated Show resolved Hide resolved
gauravpurohit06 and others added 2 commits February 22, 2024 16:45
* test: Adding integration tests for static utility to create vector embeddings table.

* test: Adding add,search,delete integration tests for VectorStore.

* test: lint

* test: lint

* style: lint

* style: lint

* Empty-Commit to trigger tests

* test: addressing review comments.

* test: test fix

* adding bs4 in test dependencies

---------

Co-authored-by: Averi Kitsch <[email protected]>
@gauravpurohit06 gauravpurohit06 merged commit 9cbae82 into main Feb 22, 2024
7 checks passed
@gauravpurohit06 gauravpurohit06 deleted the langchain-vector-store branch February 22, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/langchain-google-spanner-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants