Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Sample Netflix Application #28

Merged
merged 4 commits into from
Feb 29, 2024
Merged

docs: Update Sample Netflix Application #28

merged 4 commits into from
Feb 29, 2024

Conversation

tabbyl21
Copy link
Collaborator

In this commit we make two changes to the sample Netflix Application. 1) We change the link to the collab so it opens one for Spanner not CloudSQl (previosly it opened a link to cloud-sql's project) 2) We amend the pip install so that we pip install the Spanner package.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

In this commit we make two changes to the sample Netflix Application. 
1) We change the link to the collab so it opens one for Spanner not CloudSQl (previosly it opened a link to cloud-sql's project)
2) We amend the pip install so that we pip install the Spanner package.
@tabbyl21 tabbyl21 requested a review from a team as a code owner February 29, 2024 00:07
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label Feb 29, 2024
@tabbyl21 tabbyl21 requested a review from averikitsch February 29, 2024 00:08
In this commit we amend the pip install for Spanner's Langchain integration from "langchain_google_spanner" to "langchain-google-spanner"
In this commit we update the sample Netflix Application notebook. We link to the proper colab url.
samples/langchain_quick_start.ipynb Outdated Show resolved Hide resolved
We change to the proper langchain google vertex ai package.

Co-authored-by: Averi Kitsch <[email protected]>
@tabbyl21 tabbyl21 merged commit 2508ca8 into main Feb 29, 2024
7 checks passed
@tabbyl21 tabbyl21 deleted the tabbyl21-patch-1 branch February 29, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/langchain-google-spanner-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants