Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update mininum support to Python 3.9, Pandas 1.5.0, Numpy 1.20.3 #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Jul 31, 2024

#284 introduce the ArrowExtensionArray dependency, which requires pandas version 1.5.0 and above. The pandas 1.5.0+ is only compatible with Python 3.8+ and NumPy 1.20.3+.

  • Fixes internal bug b/312728178 (design doc: go/bf-json)
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal bug b/312728178 🦕

@chelsea-lin chelsea-lin requested a review from tswast July 31, 2024 20:33
@chelsea-lin chelsea-lin requested review from a team as code owners July 31, 2024 20:33
@tswast
Copy link
Collaborator

tswast commented Jul 31, 2024

Looks like unit (3.7) is still marked as required. Could you send a PR creating a sync-repo-setting.yml first? The if one isn't created then, this is used: https://github.com/googleapis/repo-automation-bots/blob/19bb823389a77e22d00371cb53ecadab4a58ab9e/packages/sync-repo-settings/src/required-checks.json#L50

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Aug 1, 2024
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chelsea-lin chelsea-lin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 2, 2024
@Linchin
Copy link
Contributor

Linchin commented Aug 16, 2024

@chalmerlowe has been working on an effort to drop support for python 3.7 and 3.8 (see internal doc go/drop-python-37). We likely will need to drop the support in sync with that.

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_chore branch from 3ccb77c to 0b3753d Compare January 17, 2025 18:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. size: l Pull request size is large. and removed size: s Pull request size is small. labels Jan 17, 2025
@chelsea-lin chelsea-lin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 17, 2025
@chelsea-lin chelsea-lin changed the title deps: Update mininum support to Python 3.8, Pandas 1.5.0, Numpy 1.20.3 deps: Update mininum support to Python 3.9, Pandas 1.5.0, Numpy 1.20.3 Jan 17, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_chore branch from 761e56c to 22526c1 Compare January 17, 2025 19:53
@chelsea-lin chelsea-lin requested a review from a team as a code owner January 17, 2025 19:53
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are removing this, please update constraints-3.9.txt to include all the minimum versions from setup.py

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_chore branch from 5762960 to 0564266 Compare January 17, 2025 22:23
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_chore branch from 0564266 to 6e7adaa Compare January 17, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants