Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam TOTP support #2980

Closed
wants to merge 0 commits into from
Closed

Steam TOTP support #2980

wants to merge 0 commits into from

Conversation

nikicat
Copy link
Contributor

@nikicat nikicat commented Oct 27, 2024

This PR adds Steam TOTP encoding support. totp:// url should contain encoding=steam query parameter.

@nikicat
Copy link
Contributor Author

nikicat commented Oct 27, 2024

Related to #2566

@AnomalRoil AnomalRoil marked this pull request as ready for review October 27, 2024 16:34
go.mod Outdated
@@ -2,6 +2,8 @@ module github.com/gopasspw/gopass

go 1.23.2

replace github.com/pquerna/otp => github.com/nikicat/otp v1.4.0-ojo
Copy link
Member

@AnomalRoil AnomalRoil Oct 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be too much of a supply chain attack risk, and also replace statement in a go.mod aren't meant to be shipped in a library, and some bits of gopass are acting as a library, so not great.

Any chance you could upstream that to pquerna/otp or provide the derivation in our code directly?

We're trying to generally reduce the number of dependencies, not add new ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to merge this change upstream, that's why I've created a draft PR. I think conversion from a standard digital code format is possible, but is a bit hacky, as it needs to requires at least 8 digits code to be requested and then reencoded to Steam's base26 format.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry I fat fingered the undraft button when trying to authorize the Github Action

@dominikschulz dominikschulz self-requested a review October 27, 2024 22:18
@AnomalRoil AnomalRoil marked this pull request as draft November 20, 2024 03:05
@nikicat nikicat closed this Dec 15, 2024
@nikicat nikicat mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants