feat(getallassets) : add support for include_fields in request to limit the response. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5729062398
💛 - Coveralls |
bsushmith
reviewed
Aug 2, 2023
Comment on lines
+29
to
+33
| fields := flt.IncludeFields | ||
|
|
||
| var builder sq.SelectBuilder | ||
| if len(fields) == 0 { | ||
| builder = r.getAssetSQL().Offset(uint64(flt.Offset)) |
There was a problem hiding this comment.
Are these changes necessary since search assets can also serve a similar purpose using ES?
Last time we came across changing these functionalities - we were aligning on enhancing the searchAssets API itself and consolidate both APIs into one. Context - raystack#201 (comment)
PS. search API also supports pagination now.
There was a problem hiding this comment.
Thanks for bringing this up @bsushmith. In my initial discussion with @anjali9791 I missed bringing it up.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #48