feat: envoy control plane #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mabdh
reviewed
Nov 5, 2024
mabdh
reviewed
Nov 5, 2024
mabdh
reviewed
Nov 28, 2024
cmd/serve.go
Outdated
Comment on lines
184
to
186
| if cfg.Proxy.EnvoyAgent.XDS.Host != "" && cfg.Proxy.EnvoyAgent.XDS.Port != 0 { | ||
| cbs, err = serveXDS(ctx, logger, cfg.Proxy, pgRuleRepository) | ||
| } else { |
There was a problem hiding this comment.
Does this mean if we pass host and port of envoy agent, this will use envoy otherwise it is falling back to the old proxy?
If yes, let's not do that way. Let's have an explicit config to choose.
mabdh
reviewed
Nov 28, 2024
| type ServicesConfig struct { | ||
| Services []Config `yaml:"services" mapstructure:"services"` | ||
| EnvoyAgent EnvoyAgent `yaml:"envoy" mapstructure:"envoy"` |
There was a problem hiding this comment.
let's update the config in https://github.com/goto/shield/blob/main/config/config.yaml with the example on how to use this envoy agent?
mabdh
reviewed
Nov 28, 2024
internal/proxy/envoy/xds/ads/ads.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| CLUSTER_TYPE_URL = "type.googleapis.com/envoy.config.cluster.v3.Cluster" |
There was a problem hiding this comment.
can we reuse the url from this repo instead? https://github.com/envoyproxy/go-control-plane/blob/fc612d4a3afabcbec1906fcd28df0f46adf6999b/pkg/resource/v3/resource.go#L19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control plane for envoy.