Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified isfread to work with Python 3 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Modified isfread to work with Python 3 #2

wants to merge 2 commits into from

Conversation

a-card
Copy link

@a-card a-card commented Jul 30, 2018

  • The code is still compatible with Python 2.
  • Switched to using 'with' to handle ISF file opening/closing
  • Removed unnecessary ISF filetype check. Tested using this exact type of ISF file.
  • Removed trailing whitespace

A Card added 2 commits July 30, 2018 12:50
Modify isfread to make it compatible with Python 3
91fbc95 
The code is still Python 2 compaitble. Had to switch to over to reading data
in as raw bytes. Also switched over to using 'with' to open the file. Removed trailing whitespaces.
Remove unnecessary ISF filetype check
fc3e440 
Tested this by reading an ISF file that matched the
'non-compatible' ISF file type. Turns out isfread is in fact compatible
with these parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a-card