Add support for new(ish) Sony focus APIs #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Recognise MPO movie file type - Rename near/far control to manual focus adjust as that's what it does
- Added property to retrieve the focal position of the lens. The value range is: 0 (focus near) - 100 (focus infinity). Camera must be in manual focus mode. Value can be adjusted by 'manualfocus' (if lens is in AF mode). get-config focalposition - Added control to set the autofocus spot area. Camera must be set to an AF mode and focusarea has to be set to one of the Spot Focus modes. Center of the area is specified in x,y coordinates. 0 <= X <= 639 (left -> right). 0 <= Y <= 479 (top -> bottom). The following will position the area in the center of the screen: set-config spotfocusarea=320,240
msmeissn
reviewed
Jan 31, 2025
camlibs/ptp2/config.c
Outdated
| // Camera must be set to an autofocus mode and focusarea has to be set to one of the Spot Focus modes | ||
|
|
||
| currentVal = dpd->CurrentValue.u32; | ||
| x = (int)(currentVal >> 16 & 0xffff); |
There was a problem hiding this comment.
please add additional brackets ((currentVal >> 16) & 0xfff)
There was a problem hiding this comment.
Ok, added. Sorry, not sure why I was so stingy with the brackets! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new(ish) Sony focus APIs
Added property to retrieve the focal position of the lens. The value range is: 0 (focus near) - 100 (focus infinity).
Camera must be in manual focus mode. Value can be adjusted by 'manualfocus' (if lens is in AF mode).
get-config focalposition
Added control to set the autofocus spot area. Camera must be set to an AF mode and focusarea has to be set to one of the Spot Focus modes. Center of the area is specified in x,y coordinates. 0 <= X <= 639 (left -> right). 0 <= Y <= 479 (top -> bottom). The following will position the area in the center of the screen:
set-config spotfocusarea=320,240
Add labels for more Sony properties / controls