Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcast coverart is now included as property into Episode #8

Merged
merged 1 commit into from
Aug 11, 2019

Conversation

sfbg
Copy link
Contributor

@sfbg sfbg commented Aug 10, 2019

Having access to the cover art for each Episode, and not only Podcast, is useful for showing it:

  • In the Now playing view
  • In Filtered lists with episodes from different podcasts

@carmenfdezb
Copy link
Contributor

Hi @sfbg, I've tested your pull request, I don't get any errors but I don't see any changes in app. Is it possible that something is missing in code?

@sfbg
Copy link
Contributor Author

sfbg commented Aug 10, 2019

@carmenfdezb this PR does nothing that is visible in the app, it just enables things that can be done on gpodder/gpodder-sailfish.
Like this:
image

I will create a PR there with the stuff I am doing shown above.

@sfbg
Copy link
Contributor Author

sfbg commented Aug 10, 2019

See this branch for the visible changes I am currently working on.

@carmenfdezb
Copy link
Contributor

It looks nice!!

@carmenfdezb carmenfdezb merged commit 14e711d into gpodder:master Aug 11, 2019
@sfbg sfbg deleted the coverart branch August 11, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants