Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to allow overriding some native-image parameters from com… #683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

melix
Copy link
Collaborator

@melix melix commented Jan 22, 2025

…mand line

Fixes #475

@melix melix added this to the 0.10.6 milestone Jan 22, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 22, 2025
@melix melix requested a review from dnestoro January 23, 2025 10:37
@dnestoro
Copy link
Collaborator

Looks good to me! Can we just add few tests where we show that this actually overrides options specified in the build files?

@melix
Copy link
Collaborator Author

melix commented Jan 23, 2025

Not sure if it's worth the effort, that would significantly increase build times for a feature which should be tested in Gradle itself.

@dnestoro
Copy link
Collaborator

Also (just for my better understanding) how do we know that this will override existing option? Is there a defined order what option (from build files or command line) applies first? Like, are we sure that we will always load options from a build file first, and only then the options from the command line (so that the override is always achieved)?

@melix
Copy link
Collaborator Author

melix commented Jan 23, 2025

We know because the convention values of the tasks are set from the extension, and that the overrideXXX methods are using the set method, so it's guaranteed to override. If it wasn't the case that would be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support to pass build args from the command line in the Gradle plugin
2 participants