-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for kind, status, instrumentation library, links, events and state data for traces #1043
base: main
Are you sure you want to change the base?
Conversation
…e data for traces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Glad to see expanded functionality for the trace columns. I've added a note regarding the intended table schema
@@ -49,6 +49,13 @@ const otel129: OtelVersion = { | |||
[ColumnHint.TraceTags, 'SpanAttributes'], | |||
[ColumnHint.TraceServiceTags, 'ResourceAttributes'], | |||
[ColumnHint.TraceStatusCode, 'StatusCode'], | |||
[ColumnHint.TraceKind, 'SpanKind'], | |||
[ColumnHint.TraceStatusMessage, 'StatusMessage'], | |||
[ColumnHint.TraceInstrumentationLibraryName, 'InstrumentationLibraryName'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed theres a few columns defined in otel.ts
that don't exist on the ClickHouse OTel exporter default schema. The intent of these definitions is to match as closely as possible to this table schema for a better out of the box experience.
Should we look into adding these columns to the otel exporter?
Also note that State
is defined too, but on the table it is called TraceState
.
Also AFAIU In the default schema Links is a Nested table and you need to select the fields individually:
|
@Sup3rGeo not disputing the table schema, but @SpencerTorres @benceszikora is it worth splitting the bits of this PR that can work with the current schema into something that's mergeable now? In my case I'm itching for span events to be supported, and this achieves that out of the box which is really nice. |
This PR adds support for the kind, status, instrumentation library, links, events and state fields in the trace panel in Grafana. This will bring the plugin to feature parity with what Tempo can offer today.