Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm) - remove redundant ingester podAntiAffinity expression #16902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shlomitubul
Copy link

What this PR does / why we need it:
This PR removes the redundant "name" match expression from the pod anti-affinity rules for ingester pods. The current setup uses:

rollout-group In [ingester]

name NotIn [ingester-zone-]

The extra rule on the "name" label is unnecessary because the nodeSelector already ensures pods are scheduled in their correct zones, and the first rule already forces any ingester, regardless of its zone, to never be co-located on the same node. Adding the second rule with NotIn now actually causes all ingesters of a given zone to be scheduled on the same node.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • [] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md

@shlomitubul shlomitubul requested a review from a team as a code owner March 25, 2025 15:55
@CLAassistant
Copy link

CLAassistant commented Mar 25, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants