Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(distributor): Add MaxRecvMsgSize config for uncompressed message size limits #16915

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Mar 26, 2025

What this PR does / why we need it:
This PR introduces a config option to control the max received message size for uncompressed data. The default is set to 100 MB. Previously the code base allowed up to 2 GB which per push request which is obviously a long-time hanging hindsight.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 26, 2025
@periklis periklis self-assigned this Mar 26, 2025
@periklis periklis requested a review from a team as a code owner March 26, 2025 09:28
Copy link
Contributor

github-actions bot commented Mar 26, 2025

💻 Deploy preview deleted.

@slim-bean
Copy link
Collaborator

nice! we should also increment our discard metrics, we can't increment the discard lines metric because we don't have lines yet, but I think we should implement the discard bytes with a new reason code? WDYT?

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 27, 2025
@periklis periklis merged commit 1d99f4d into main Apr 1, 2025
63 checks passed
@periklis periklis deleted the distibutor-max-recv-msg-size branch April 1, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants