Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: fix using native histograms in dashboards #10018

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Nov 25, 2024

What this PR does

After prometheus/prometheus#15245 the current trick to hide queries selectively doesn't work.

Update jsonnet-lib dependency with the new solution. grafana/jsonnet-libs#1362
Documentation was updated separately: #10052

Which issue(s) this PR fixes or relates to

Fixes N/A

Checklist

  • N/A Tests updated.
  • N/A Documentation added (separate).
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

After prometheus/prometheus#15245 the
current trick to hide queries selectively doesn't work.

Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
@krajorama krajorama marked this pull request as ready for review December 9, 2024 09:54
@krajorama krajorama requested a review from a team as a code owner December 9, 2024 09:54
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for keeping this correct 🙏

@krajorama krajorama merged commit 2186af3 into main Dec 10, 2024
31 checks passed
@krajorama krajorama deleted the krajo/new-hider branch December 10, 2024 07:14
@krajorama
Copy link
Contributor Author

uses grafana/jsonnet-libs#1362

bjorns163 pushed a commit to bjorns163/mimir that referenced this pull request Dec 30, 2024
* mixin: fix using native histograms in dashboards

After prometheus/prometheus#15245 the
current trick to hide queries selectively doesn't work.

Signed-off-by: György Krajcsovits <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants