Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflict with cluster-issuer #5203

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: conflict with cluster-issuer #5203

wants to merge 2 commits into from

Conversation

sule26
Copy link

@sule26 sule26 commented Oct 24, 2024

What this PR does

Only comment out the annotation cert-manager.io/issuer: "letsencrypt-prod" so that it won’t be necessary set cert-manager.io/issuer: null when switching to cert-manager.io/cluster-issuer.

Which issue(s) this PR closes

Related to #3069

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@sule26 sule26 requested a review from a team October 24, 2024 02:00
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

@karlipegomes
Copy link

That solved my problem!
Thx @sule26

@sule26 sule26 requested a review from a team as a code owner November 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants