-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add pytest-socket
library + disable network calls in tests
#5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no public docs
Added to a PR that does not require public documentation updates
release:ignore
PR will not be added to release notes
labels
Dec 1, 2024
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 13:50
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 13:50
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 13:50
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 14:09
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 14:09
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 14:09
— with
GitHub Actions
Inactive
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:29
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:29
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:29
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:34
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:34
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:34
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:41
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:41
— with
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
December 1, 2024 14:41
— with
GitHub Actions
Error
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 14:49
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 14:49
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 1, 2024 14:49
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 14:13
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 14:13
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 14:13
— with
GitHub Actions
Inactive
matiasb
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! +1
Ferril
approved these changes
Dec 2, 2024
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 15:32
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 15:32
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 15:32
— with
GitHub Actions
Inactive
…grafana/oncall into jorlando/disable-network-calls-in-tests
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 15:47
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 15:47
— with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 2, 2024 15:47
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr:no public docs
Added to a PR that does not require public documentation updates
release:ignore
PR will not be added to release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Inspired by this discussion. tldr; ensures that if any of our tests try making an external network call, they will fail.
Setup an example test:
and it worked (failed; example CI test run) as expected:
Checklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.