Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pyroscope Profiling Integration #130

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SeamusGrafana
Copy link
Contributor

Add Support for the Go Profiles GitHub Integration in Grafana Cloud.

Add Support for the Span Profiles to Traces Feature

Some Minor updates to README.md to fix some misc Lint Issues, and improve Docs.

@federicotdn
Copy link
Contributor

@SeamusGrafana would you mind adapting this to main? I had to fix some middleware-related things, see comment in #143.

@SeamusGrafana
Copy link
Contributor Author

SeamusGrafana commented Jan 21, 2025

Thanks @federicotdn

Have done that and tested locally, I can see the pyroscope.profile.id in some Spans.

image

But not all, mostly the newer ones;

image

Have I missed it somewhere?

Thanks

@federicotdn
Copy link
Contributor

I've changed the service name attribute for those endpoints, could you merge main again?
Also, I assume you are building a new QP image locally and running that one. The one in Dockerhub will always be slightly behind.

@SeamusGrafana
Copy link
Contributor Author

Also, I assume you are building a new QP image locally and running that one. The one in Dockerhub will always be slightly behind.

Yeah, using make to build it and running the Binary directly.

Will test shortly, thanks!

@SeamusGrafana SeamusGrafana requested a review from a team as a code owner January 22, 2025 16:11
@SeamusGrafana SeamusGrafana requested review from Blinkuu and vortegatorres and removed request for a team January 22, 2025 16:11
@SeamusGrafana
Copy link
Contributor Author

Thanks @federicotdn

I tried again but got the same results as before.

@federicotdn
Copy link
Contributor

Aah ok. Could you share what set of commands you are using locally to test this? I can try reproducing it locally.

@SeamusGrafana
Copy link
Contributor Author

Thanks @federicotdn

From the root of the branch;

docker buildx build .

Copy the SHA256 for the gernated image, and it add it into here;

version: '3'

services:
  quickpizza:
    image: <IMAGE-SHA256>
    container_name: quickpizza
    environment:
      OTEL_RESOURCE_ATTRIBUTES: service.namespace=quickpizza
      QUICKPIZZA_CONF_FARO_URL: ${QUICKPIZZA_FARO_RECEIVER:-http://alloy:12347/collect}
      QUICKPIZZA_LOG_LEVEL: ${QUICKPIZZA_LOG_LEVEL:-debug}
      QUICKPIZZA_OTLP_ENDPOINT: ${QUICKPIZZA_OTLP_ENDPOINT:-http://alloy:4318}
      QUICKPIZZA_PYROSCOPE_ENDPOINT: ${QUICKPIZZA_PYROSCOPE_ENDPOINT:-http://pyroscope:4040}
      QUICKPIZZA_PYROSCOPE_NAME: ${QUICKPIZZA_PYROSCOPE_NAME:-quickpizza}
      QUICKPIZZA_TRUST_CLIENT_TRACEID: 1
      VIRTUAL_HOST: ${QUICKPIZZA_VIRTUAL_HOST:-quickpizza.lab}
    ports:
      - ${QUICKPIZZA_PORT:-3333}:3333
      - ${QUICKPIZZA_PORT_GRPC_1:-3334}:3334
      - ${QUICKPIZZA_PORT_GRPC_2:-3335}:3335
    restart: on-failure
    labels:
      namespace: quickpizza

Run docker compose up

Navigate to QP site in browser, genertae few pizzas, then test new delay endpoint.

I have an Alloy, Mimir, Loki, Tempo and Pyroscope already configured where QP sends data too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants