WIP: generator registry stale markers #4853
Draft
+231
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
reviewed
Mar 17, 2025
joe-elliott
reviewed
Mar 18, 2025
rlankfo
force-pushed
the
rlankfo/metrics-gen-registry-stale-markers
branch
from
3b14573 to
5d759ea
Compare
rlankfo
force-pushed
the
rlankfo/metrics-gen-registry-stale-markers
branch
from
cc7175c to
488efcc
Compare
mattdurham
reviewed
Mar 26, 2025
| @@ -147,30 +150,55 @@ func (c *counter) collectMetrics(appender storage.Appender, timeMs int64) (activ | |||
| endOfLastMinuteMs := getEndOfLastMinuteMs(timeMs) | |||
| _, err = appender.Append(0, s.labels, endOfLastMinuteMs, 0) | |||
| if err != nil { | |||
| c.seriesMtx.RUnlock() | |||
There was a problem hiding this comment.
Do you think we can avoid this manual unlocking? Makes it very easy to have a danging deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds stale marker support to the metrics generator registry. A series is marked stale when it's stale duration has elapsed. During the next collection interval, any series marked stale will append a stale marker value before removal from the metric's series map.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]