Fixes for Indexing Section #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
idalithb
commented
Jun 3, 2025
idalithb
commented
- Removing Agora
- Changing language around graph-node
jacordaro
approved these changes
Jun 5, 2025
encalypto
reviewed
Jun 5, 2025
Comment on lines
88
to
92
| > **Important**: Be careful about exposing ports publicly - **administration ports** should be kept locked down. This includes the the Graph Node JSON-RPC endpoint. | ||
| > **WARNING: Never expose Graph Node's administrative ports to the public**. | ||
| > | ||
| > - Exposing Graph Node's internal ports can lead to a full system compromise. | ||
| > - These ports must remain **private**: JSON-RPC Admin endpoint, Indexing Status API, and PostgreSQL. | ||
| > - Only expose 8000 (GraphQL HTTP) and 8001 (GraphQL WebSocket) if needed. Lock everything else down with firewalls or private networks. |
There was a problem hiding this comment.
Can we use stronger language here to indicate that no ports should be exposed, even 8000 / 8001? Ideally these are proxied via indexer-agent instead, and that uses some kind of production-ready proxy
idalithb
commented
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.