Skip to content

feat: integrate matchstick into the graph CLI #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: integrate matchstick into the graph CLI #1543

wants to merge 2 commits into from

Conversation

YassinEldeeb
Copy link
Member

@YassinEldeeb YassinEldeeb commented Dec 13, 2023 •
edited
Loading

cleaning up / opening it for review in a couple of hours

@YassinEldeeb YassinEldeeb marked this pull request as draft December 13, 2023 16:13
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: cfd4d68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Dec 13, 2023
Open
Open
KholdStare
KholdStare reviewed Dec 14, 2023
View reviewed changes
packages/testing-matchstick/mocks/as/gravity-tests.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question - shouldn't this be .ts instead of .txt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be. but, we're currently just starting to move a direct clone of https://github.com/LimeChain/matchstick into here to maintain our own version. We haven't yet inspected the code fully 😄

Thanks for catching that! 😄

@YassinEldeeb
Copy link
Member Author

moved into #1549 where the branch lives on the repo for CI to run properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KholdStare KholdStare KholdStare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YassinEldeeb @KholdStare