Skip to content

feat(filters): add Date & Point “is” for private and public query #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0xTaneja
Copy link
Contributor

Added Date and Point is value filters to both private and public queries.

fixes #440

Changes Made :-

for private query,
In types.ts, I extended EntityFieldFilter<T> to support Date and ReadonlyArray<number>.
Another change which i made was in ,
findMany.ts , evaluated Date via getTime() and Point via [x, y] deep equality.

for public query from what i understood from the codebase was that useQueryPublic already passes $filter and selects time/point, so no extra wiring needed.

edited translate-filter-to-graphql.ts -
Date → time: { is: Graph.serializeDate(date) }
Point → point: { is: Graph.serializePoint([x, y]) }

Added a few tests on public & private queries
No breaking changes. Only adds filter capabilities.
Applies only when users provide Date/Point filters.

@nikgraf
Copy link
Collaborator

nikgraf commented Aug 13, 2025

hey, will review this one end of the week or early next one. Currently only focusing on bug fixes and necessary features for the ETHGlobal Hackathon

@0xTaneja
Copy link
Contributor Author

okay great , take your time !! @nikgraf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add value filters for Point & Date
2 participants