Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix apollo-client link #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sduthil
Copy link

@sduthil sduthil commented Apr 9, 2020

No description provided.

@coveralls
Copy link

coveralls commented Apr 9, 2020

Coverage Status

Coverage remained the same at 93.548% when pulling 442b8b3 on sduthil:readme-apollo-client-link into 9691baf on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.548% when pulling 88ae942 on sduthil:readme-apollo-client-link into 9691baf on graphql-python:master.

README.md Outdated Show resolved Hide resolved
@KingDarBoja
Copy link
Contributor

In fact, the Apollo Client isn't only limited to React as there is one for Angular too and so on.

If you check the docs, you will see that it points to another guide at the following link for:

I think the first one is more generalized and not bound to a specific frontend framework.

Cheers!

@sduthil sduthil force-pushed the readme-apollo-client-link branch from 88ae942 to 442b8b3 Compare April 14, 2020 13:01
@sduthil
Copy link
Author

sduthil commented Apr 14, 2020

In fact, the Apollo Client isn't only limited to React as there is one for Angular too and so on.

If you check the docs, you will see that it points to another guide at the following link for:

* React: [batch-http](https://www.apollographql.com/docs/link/links/batch-http/)

* Angular: [angular-link-http-batch](https://github.com/apollographql/apollo-angular/tree/master/packages/apollo-angular-link-http-batch)

I think the first one is more generalized and not bound to a specific frontend framework.

Agreed that the doc should be as frontend-agnostic as possible. But IMHO the paragraph about query batching in the React section:

  • does not mention React
  • links to the detailed, agnostic documentation
  • gives a good example of using query batching, which I found very useful while learning GraphQL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants