New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Remove `query`, `variables`, `headers` and `response` props in `<GraphiQL />`, `<GraphiQLProvider />` and `<EditorContextProvider />` #3735

Draft

dimaMachina wants to merge 3 commits into graphiql-v4 from remove-controlled-props

Draft

[v4] Remove `query`, `variables`, `headers` and `response` props in `<GraphiQL />`, `<GraphiQLProvider />` and `<EditorContextProvider />` #3735

Apply suggestions from code review

Codecov / codecov/patch succeeded Oct 24, 2024 in 1s

63.63% of diff hit (target 67.26%)

View this Pull Request on Codecov

63.63% of diff hit (target 67.26%)

Annotations

Check warning on line 237 in packages/graphiql-react/src/editor/context.tsx

codecov / codecov/patch

packages/graphiql-react/src/editor/context.tsx#L237

Added line #L237 was not covered by tests

Check warning on line 243 in packages/graphiql-react/src/editor/context.tsx

codecov / codecov/patch

packages/graphiql-react/src/editor/context.tsx#L243

Added line #L243 was not covered by tests

Check warning on line 249 in packages/graphiql-react/src/editor/context.tsx

codecov / codecov/patch

packages/graphiql-react/src/editor/context.tsx#L249

Added line #L249 was not covered by tests

Check warning on line 255 in packages/graphiql-react/src/editor/context.tsx

codecov / codecov/patch

packages/graphiql-react/src/editor/context.tsx#L255

Added line #L255 was not covered by tests

View more details on Codecov