-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CodSpeed Benchmarks #4243
Open
erikwrede
wants to merge
24
commits into
graphql:main
Choose a base branch
from
erikwrede:feat/codspeed-vitest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
114d936
experiment: add codspeed
erikwrede 016acb6
fix: make esm loader happy
erikwrede ccf912d
fix: use correct node command
erikwrede 3b899ec
chore: trigger codspeed run
erikwrede 06734cf
experiment: add codspeed using vitest
erikwrede fe41a4c
chore: lint
erikwrede 71a3028
fix: revert import broken by lint
erikwrede dd0629f
experiment: try out patching
erikwrede 1425baa
chore: enable env:
erikwrede 64729f8
trigger codspeed
erikwrede 9c713c9
fix: adjust ci & lint to new benchmarks
erikwrede badafc1
refactor: remove types/chai to prevent type conflicts. they now come …
erikwrede e43ff47
chore: prettier
erikwrede e1f79a2
fix: commonly ignored files
erikwrede ef74c7d
chore: prettier
erikwrede 3c83dfd
chore: add codspeed to spellcheck
erikwrede d88e025
chore: remove unused codspeed command
erikwrede 9c771c0
fix: rename files
erikwrede b5b3049
chore: patch codspeed
erikwrede 04fa980
chore: fix patch
erikwrede 6c49c41
chore: remove tinybench plugin
erikwrede 8eb26fb
fix: adjust commonly ignored files workflow
erikwrede 0cc1c05
chore: unpin tinybench
erikwrede 0574c6b
Merge remote-tracking branch 'origin/main' into feat/codspeed-vitest
erikwrede File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,6 @@ | |
|
||
# Ignore TS files inside integration test | ||
/integrationTests/ts/*.ts | ||
|
||
# Ignore config files | ||
/vitest.config.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: CodSpeed Benchmarks | ||
|
||
on: | ||
push: | ||
branches: | ||
- 'main' # or "master" | ||
pull_request: | ||
# `workflow_dispatch` allows CodSpeed to trigger backtest | ||
# performance analysis in order to generate initial data. | ||
workflow_dispatch: | ||
|
||
jobs: | ||
benchmarks: | ||
name: Run benchmarks | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: 'actions/checkout@v4' | ||
- uses: 'actions/setup-node@v3' | ||
- name: Install dependencies | ||
run: npm install | ||
- name: Run benchmarks | ||
uses: CodSpeedHQ/action@v3 | ||
env: | ||
CODSPEED_FORCE_OPTIMIZATION: true | ||
with: | ||
run: npm exec vitest bench | ||
token: ${{ secrets.CODSPEED_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,9 @@ ignorePaths: | |
- package.json | ||
- benchmark/github-schema.graphql | ||
- benchmark/github-schema.json | ||
- patches | ||
- src/__benchmarks__/github-schema.json | ||
- src/__benchmarks__/github-schema.graphql | ||
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could merge these two with the existing benchmark resource files into a shared folder |
||
overrides: | ||
- filename: '**/docs-old/APIReference-*.md' | ||
ignoreRegExpList: ['/href="[^"]*"/'] | ||
|
@@ -34,7 +37,7 @@ ignoreRegExpList: | |
|
||
words: | ||
- graphiql | ||
|
||
- codspeed | ||
# Different names used inside tests | ||
- Skywalker | ||
- Leia | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revert this as soon as
codspeed
doesn't require the patch anymore