Skip to content

add deprecated note to assertValidExecutionArguments #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.x.x
Choose a base branch
from
Open

add deprecated note to assertValidExecutionArguments #4336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/execution/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ function buildResponse(
* Essential assertions before executing to provide developer feedback for
* improper use of the GraphQL library.
*
* @deprecated will be removed in v17 in favor of assertValidSchema() and TS checks
* @internal
*/
export function assertValidExecutionArguments(
Expand Down
2 changes: 2 additions & 0 deletions src/execution/subscribe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import type {
ExecutionResult,
} from './execute';
import {
// eslint-disable-next-line import/no-deprecated
assertValidExecutionArguments,
buildExecutionContext,
buildResolveInfo,
Expand Down Expand Up @@ -160,6 +161,7 @@ export async function createSourceEventStream(

// If arguments are missing or incorrectly typed, this is an internal
// developer mistake which should throw an early error.
// eslint-disable-next-line import/no-deprecated
assertValidExecutionArguments(schema, document, variableValues);

// If a valid execution context cannot be created due to incorrect arguments,
Expand Down