Skip to content

Add benjie's suggested changes to schema-coordinates #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Add benjie's suggested changes to schema-coordinates #4478

merged 1 commit into from
Aug 27, 2025
+110 −32

Conversation

magicmark
Copy link
Contributor

Adding @benjie's changes here #3044

@magicmark magicmark requested a review from a team as a code owner August 26, 2025 22:14
@magicmark
Copy link
Contributor Author

magicmark commented Aug 27, 2025 •
edited
Loading

#4479 should fix the failing ci check

benjie
benjie approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves tests and types but has no runtime impact - looks good to me, I'm going to go ahead and merge it 👍

@benjie benjie merged commit fe0ad30 into graphql:schema-coordinates Aug 27, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicmark @benjie