Add retry logic on git submodule loads #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes a transient network error prevents git submodule loads from succeeding while building the docs site. Edit the `update_submodules.sh` script to add rudimentary retry logic. If `git submodule update` fails, retry the command for up to five attempts, with the time between retries increasing by five seconds each time. This change introduces this approach because it is not possible to configure HTTP request retries in the git config, nor is there a curl environment variable we can set to enable retries in git's `https://` transport.
|
Amplify deployment status
|
taraspos
reviewed
Jan 17, 2025
Co-authored-by: Taras <[email protected]>
taraspos
approved these changes
Jan 17, 2025
Retry logic works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a transient network error prevents git submodule loads from succeeding while building the docs site. Edit the
update_submodules.shscript to add rudimentary retry logic. Ifgit submodule updatefails, retry the command for up to five attempts, with the time between retries increasing by five seconds each time.This change introduces this approach because it is not possible to configure HTTP request retries in the git config, nor is there a curl environment variable we can set to enable retries in git's
https://transport.