Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: Allow setB to be a single approver #209

Merged
merged 1 commit into from
Jan 4, 2024
Merged

bot: Allow setB to be a single approver #209

merged 1 commit into from
Jan 4, 2024

Conversation

jimbishopp
Copy link
Contributor

@jimbishopp jimbishopp commented Jan 3, 2024

#206 added support for a single approver but did not include single approvers from group B.

  1. Updated the check logic to allow a single approval from setB
  2. Added use cases to the internal unit test
  3. Added a log line to print the number of required approvers for a PR

@jimbishopp jimbishopp requested review from a team January 3, 2024 20:21
@jimbishopp jimbishopp merged commit ae09746 into main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants