feat(Gallery): add Gallery component #247
Conversation
kseniya57
requested review from
KirillDyachkovskiy,
amje,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
| @@ -0,0 +1,18 @@ | |||
| import React from 'react'; | |||
|
|
|||
| import {FilePreview} from '../../FilePreview'; | |||
There was a problem hiding this comment.
It's better to use FIlePreview component from gravity-ui/uikit. Current component will be removed in next major
There was a problem hiding this comment.
There is no such export.
There was a problem hiding this comment.
need version 6.35.0 of uikit(
| className={cnVideoFileView(null, className)} | ||
| src={src} | ||
| controls | ||
| autoPlay |
There was a problem hiding this comment.
It's impossible to interact with video after its panel is gone. Hover does not work and click switches the file. Is that how it's supposed to work?
Auto-play can also be quite annoying in such a case.
There was a problem hiding this comment.
| Auto-play can also be quite annoying in such a case.
This is already user tested scenario. But I can make the autoplay optional.
| } as File, | ||
| }, | ||
| { | ||
| type: 'document', |
There was a problem hiding this comment.
It is not displayed. Is this how it should be?
There was a problem hiding this comment.
This is just an example, mock pdf file, I can't find a correct link. The service should implement the document functionality itself.
|
@kseniya57 Do we have rfc fo this components? |
|
Yes |
kseniya57
force-pushed
the
gallery
branch
3 times, most recently
from
401a5d6 to
8c07955
Compare
kseniya57
force-pushed
the
gallery
branch
2 times, most recently
from
855b632 to
772a07f
Compare
kseniya57
changed the title
Add the components for rendering galleries (base gallery and the files gallery with file previews and some pre-defined active file renderers)