feat(DataSource): add the transformError data-source function #24
Conversation
| @@ -6,11 +6,14 @@ export type DataSourceTag = string; | |||
| declare const errorHintSymbol: unique symbol; | |||
| declare const stateHintSymbol: unique symbol; | |||
|
|
|||
| export type NonNullableUnknown = NonNullable<unknown>; | |||
There was a problem hiding this comment.
suggestion(blocking): Let's move it to utils.ts
| * When set, the `fetch` errors will be transformed into data without changing the state to error. | ||
| * @returns NonNullable | ||
| */ | ||
| transformError?: (reason: unknown) => TResponseErrorTransform; |
There was a problem hiding this comment.
suggestion(non-blocking): reason -> error
| export interface DataSource< | ||
| TContext, | ||
| TParams, | ||
| TRequest, | ||
| TResponse, | ||
| TResponseErrorTransform extends NonNullableUnknown, |
There was a problem hiding this comment.
issue(blocking): Move it after TError and add default like TResponseErrorTransform extends NonNullableUnknown = NonNullableUnknown to avoid breaking changes
| export interface DataSource< | ||
| TContext, | ||
| TParams, | ||
| TRequest, | ||
| TResponse, | ||
| TResponseErrorTransform extends NonNullableUnknown, |
There was a problem hiding this comment.
suggestion(non-blocking): TResponseErrorTransform -> TErrorResponse
| * When set, the `fetch` errors will be transformed into data without changing the state to error. | ||
| * @returns NonNullable | ||
| */ | ||
| transformError?: (reason: unknown) => TResponseErrorTransform; |
There was a problem hiding this comment.
question(blocking): Can we use TError here instead of unknown?
| infer TData, | ||
| infer _TError, | ||
| infer _TOptions, | ||
| infer _TState, | ||
| infer _TFetchContext | ||
| > | ||
| ? ActualData<TData, TResponse> | ||
| ? ActualData<TResponse, TResponseErrorTransform, TData> | ||
| : never; | ||
|
|
||
| export type DataSourceError<TDataSource> = |
There was a problem hiding this comment.
suggestion(blocking): Add DataSourceErrorResponse for inferring like DataSourceError
| unknown extends TResponseErrorTransform ? TResponse : TResponse | TResponseErrorTransform; | ||
|
|
||
| export type ActualData<TResponse, TResponseErrorTransform, TData> = unknown extends TData | ||
| ? unknown extends TResponseErrorTransform |
There was a problem hiding this comment.
suggestion(blocking): Looks like you can use ActualResponse here
| QueryDataSourceContext, | ||
| TParams, | ||
| TRequest, | ||
| TResponse, | ||
| TResponseErrorTransform, | ||
| TData, | ||
| TError, | ||
| InfiniteQueryObserverExtendedOptions< | ||
| TResponse, |
There was a problem hiding this comment.
issue(blocking): You have to wrap TResponse using ActualResponse in the TOptions and TState types
When the
transformErroris set, thefetcherrors will be transformed into data without changing the state to error.