feat(YfmTabs): switch between tabs using tabs-extension runtime #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhnatkin
approved these changes
Jan 17, 2025
|
Preview is ready. |
|
I believe this is an issue with the current tab implementation in Diplodoc (id of tabs), but it seems to have become more noticeable with the recent changes to tabs. Storybrook scripts intercept clicks Here’s the scenario: In the old code, this issue doesn’t occur in this case (though it does if I fill in everything except the first tab). Screen.Recording.2025-01-20.at.17.45.15.movIn the new code, I can’t enter anything at all. Screen.Recording.2025-01-20.at.17.46.21.movPlease check it |
makhnatkin
reviewed
Jan 20, 2025
d3m1d0v
force-pushed
the
d3m1d0v/yfm-tabs-switch-runtime
branch
from
d612670 to
b278a8d
Compare
d3m1d0v
force-pushed
the
d3m1d0v/yfm-tabs-switch-runtime
branch
from
b278a8d to
ee8095c
Compare
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.