Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Divider): border-width CSS API #1758

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spotikhanov
Copy link
Contributor

This change resolves #1652 by adding the option to style divider's border-width with CSS API.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=ru.

@spotikhanov spotikhanov requested a review from v4dyar4 as a code owner August 17, 2024 09:12
@v4dyar4
Copy link
Contributor

v4dyar4 commented Aug 20, 2024

@spotikhanov Hi! I suggest you wait for previous PR to be merged. Maybe you'll wanna add changes

#1701 (review)

@v4dyar4
Copy link
Contributor

v4dyar4 commented Aug 23, 2024

@spotikhanov You can rebase branch from main. Previous PR was merged

@spotikhanov spotikhanov force-pushed the divider-border-width-css-api branch from ee9999d to 307a058 Compare August 23, 2024 20:53
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@spotikhanov spotikhanov force-pushed the divider-border-width-css-api branch 2 times, most recently from 77855a7 to 65b18e0 Compare August 23, 2024 21:17
@spotikhanov
Copy link
Contributor Author

@v4dyar4 Hi! Rebased with the latest changes. Changed --g-divider-border-width to --g-divider-size for consistency with #1701

@spotikhanov spotikhanov force-pushed the divider-border-width-css-api branch 2 times, most recently from 4a4896a to 8c0db39 Compare August 30, 2024 10:54
@spotikhanov spotikhanov force-pushed the divider-border-width-css-api branch from 8c0db39 to 1416276 Compare August 31, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSS API for Divider width
4 participants