Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open modal for the whole page #2009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

iapolya
Copy link

@iapolya iapolya commented Dec 21, 2024

Modal window state stretched to full page, no mardin, no border radius. Useful on mobile.

@iapolya iapolya requested a review from amje as a code owner December 21, 2024 17:14
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@amje
Copy link
Contributor

amje commented Dec 24, 2024

@iapolya Hi, Modal is not supposed to be open in fullscreen by design. It has no "close" element except its overlay. So it won't be possible to close the Modal on mobile device in such scenario. There is a dedicated component for mobile cases - Sheet, which should be used instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants