Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Select): keyboard behavior on mobile #2082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Select): keyboard behavior on mobile #2082

wants to merge 1 commit into from

Conversation

iapolya
Copy link

@iapolya iapolya commented Jan 31, 2025 •
edited
Loading

There are cases when the select with an open keyboard behaves inconveniently for the user

  1. Auto-closing of Select when the keyboard is closed. Reproduced in Safari and Yandex Browser on iOS

Click on "Готово" button

IMG_2814.MP4
  1. The keyboard opens after selecting item. This is inconvenient because it requires the user to close the keyboard if they want to select an item from the list located nearby
IMG_2815.MP4

Questions:

  1. For which cases might we need useFocusWithin in a mobile select?
  2. Сan I remove filterRef.current?.focus() on mobile?

@iapolya iapolya requested a review from korvin89 as a code owner January 31, 2025 16:42
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@korvin89
Copy link
Contributor

@iapolya Hi! Could u fix failed test?

@iapolya iapolya requested review from amje and ValeraS as code owners January 31, 2025 17:07
@iapolya iapolya force-pushed the feat/select-close-on-mobile branch from 0c78b44 to 73c056a Compare January 31, 2025 17:14
@iapolya iapolya force-pushed the feat/select-close-on-mobile branch from 73c056a to e9c0afa Compare January 31, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 Awaiting requested review from korvin89 korvin89 is a code owner

@amje amje Awaiting requested review from amje amje is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iapolya @gravity-ui-bot @korvin89