Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: bump @mantine/core from 7.13.4 to 7.15.2 #4266

Merged
merged 5 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 58 additions & 53 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"dependencies": {
"@atlaskit/pragmatic-drag-and-drop-react-beautiful-dnd-migration": "^1.2.4",
"@greenbone/opensight-ui-components-mantinev7": "^0.0.7-alpha3",
"@mantine/core": "^7.12.1",
"@mantine/core": "^7.15.2",
"@reduxjs/toolkit": "^2.5.0",
"@sentry/react": "^8.39.0",
"@visx/axis": "^3.12.0",
Expand Down
3 changes: 1 addition & 2 deletions src/web/components/dialog/confirmationdialog.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/


import DialogContent from 'web/components/dialog/content';
import Dialog from 'web/components/dialog/dialog';
import DialogTwoButtonFooter, {
Expand All @@ -30,7 +29,6 @@ const ConfirmationDialog = ({

return (
<Dialog
data-testid="confirmation-dialog"
footer={
<DialogTwoButtonFooter
loading={loading}
Expand All @@ -40,6 +38,7 @@ const ConfirmationDialog = ({
onRightButtonClick={onResumeClick}
/>
}
testId="confirmation-dialog"
title={title}
width={width}
onClose={onClose}
Expand Down
7 changes: 5 additions & 2 deletions src/web/components/dialog/dialog.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const DialogTitleButton = styled.button`
border: none;
padding: 0;
outline: none;
cursor: ${({isDragging}) => (isDragging ? 'grabbing' : 'grab')};
cursor: ${({$isDragging}) => ($isDragging ? 'grabbing' : 'grab')};
display: flex;
align-items: center;
width: 100%;
Expand Down Expand Up @@ -71,6 +71,7 @@ const Dialog = ({
onClose,
height = MODAL_HEIGHT,
width = MODAL_WIDTH,
testId = 'dialog-test-id',
}) => {
const [isResizing, setIsResizing] = useState(false);

Expand Down Expand Up @@ -132,14 +133,15 @@ const Dialog = ({
return (
<StyledModal
centered={false}
data-testid={testId}
height={height}
opened={true}
position={position}
size="auto"
title={
<DialogTitleButton
$isDragging={isDragging}
className="dialog-title-button"
isDragging={isDragging}
type="button"
onKeyDown={e => {
if (e.key === 'Enter' || e.key === ' ') {
Expand Down Expand Up @@ -172,6 +174,7 @@ const Dialog = ({

Dialog.propTypes = {
children: PropTypes.oneOfType([PropTypes.func, PropTypes.node]),
testId: PropTypes.string,
footer: PropTypes.node,
title: PropTypes.string,
width: PropTypes.string,
Expand Down
Loading
Loading