Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: GET_NVTS attribute skip_tags #2070

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Aug 29, 2023

What

Add attribute skip_tags to GMP GET_NVTS.

Off
time o m m '<get_nvts skip_tags="0" skip_cert_refs="1" details="1" timeout="1" family="General" preferences_config_id="55385e2f-cd85-4a4a-954a-c89495aca669" preference_count="1" sort_field="nvts.name" sort_order="ascending"/>' > /tmp/nvts
13s,10s,16s,10s

On
time o m m '<get_nvts skip_tags="1" skip_cert_refs="1" details="1" timeout="1" family="General" preferences_config_id="55385e2f-cd85-4a4a-954a-c89495aca669" preference_count="1" sort_field="nvts.name" sort_order="ascending"/>' > /tmp/nvts
9s,11s,12s,10s

Why

Allows GSA to request less info for the Edit Config Family dialog. Also saves some db querying on gvmd side.

@github-actions
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@mattmundell mattmundell marked this pull request as ready for review September 5, 2023 09:04
@mattmundell mattmundell requested a review from a team as a code owner September 5, 2023 09:04
@timopollmeier timopollmeier enabled auto-merge (rebase) October 4, 2023 11:41
@timopollmeier timopollmeier merged commit 172e024 into greenbone:main Oct 4, 2023
9 checks passed
@mattmundell mattmundell deleted the get-nvts-skip-tags branch October 4, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants