Fix: Handle permission clause for result permissions. #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
a-h-abdelsalam
requested changes
Feb 9, 2024
a-h-abdelsalam
approved these changes
Feb 9, 2024
mattmundell
reviewed
Feb 9, 2024
| @@ -1143,13 +1143,14 @@ acl_where_owned_user (const char *user_id, const char *user_sql, | |||
| else if (strcmp (type, "result") == 0) | |||
| permission_clause | |||
| = g_strdup_printf ("%s" | |||
| " OR results%s.task IN" | |||
| " OR EXISTS" | |||
| " (SELECT id FROM %spermissions_subject" | |||
There was a problem hiding this comment.
Feels like this should be IN to match the other cases. In 28054e8 in PR #2118 @timopollmeier changed the EXISTS to IN, but he forgot to change id to resource. Maybe messed up his performance measurements, but maybe he was measuring the other cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Results of a task could not bee seen any more by a user that has read permission
to the task. This problem is fixed now.
Why
This is a bug-fix
References
GEA-477
Checklist
Tested manually on my development system.