Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Add new Report Config data type #2136

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Conversation

timopollmeier
Copy link
Member

What

This adds the new data type Report Config and the corresponding GMP commands create_report_config, delete_report_config, get_report_configs and modify_report_config.

Why

This will later allow configuring the parameters of predefined report formats when exporting reports or setting up alerts.

References

GEA-416

@timopollmeier timopollmeier requested review from mattmundell and a team as code owners February 14, 2024 09:58
Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

This adds the new data type Report Config and the corresponding GMP
commands create_report_config, delete_report_config, get_report_configs
and modify_report_config.

This will later allow configuring the parameters of predefined report
formats when exporting reports or setting up alerts.
The alerts will be included whenever details="1" is set.
src/manage_sql_report_formats.c Outdated Show resolved Hide resolved
src/manage_sql_report_formats.c Show resolved Hide resolved
src/manage_sql_report_formats.c Outdated Show resolved Hide resolved
src/manage_sql_report_configs.c Outdated Show resolved Hide resolved
src/manage_sql_report_configs.c Outdated Show resolved Hide resolved
src/manage_report_configs.h Outdated Show resolved Hide resolved
src/manage_report_configs.h Outdated Show resolved Hide resolved
src/schema_formats/XML/GMP.xml.in Show resolved Hide resolved
src/schema_formats/XML/GMP.xml.in Outdated Show resolved Hide resolved
src/schema_formats/XML/GMP.xml.in Show resolved Hide resolved
This fixes several smaller issues found by @a-h-abdelsalam's review:
- several "report format" vs. "report config" mix-ups / copy-paste errors
- the "active" column in report format iterator
- copying report format parameters
- Some GMP attributes and elements
src/manage_sql.c Outdated Show resolved Hide resolved
@a-h-abdelsalam a-h-abdelsalam merged commit baaefed into main Feb 20, 2024
9 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the add-report-configs branch February 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants