-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Add new Report Config data type #2136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
This adds the new data type Report Config and the corresponding GMP commands create_report_config, delete_report_config, get_report_configs and modify_report_config. This will later allow configuring the parameters of predefined report formats when exporting reports or setting up alerts.
timopollmeier
force-pushed
the
add-report-configs
branch
from
February 14, 2024 10:26
7b01edb
to
858ad07
Compare
This was referenced Feb 14, 2024
The alerts will be included whenever details="1" is set.
a-h-abdelsalam
requested changes
Feb 16, 2024
This fixes several smaller issues found by @a-h-abdelsalam's review: - several "report format" vs. "report config" mix-ups / copy-paste errors - the "active" column in report format iterator - copying report format parameters - Some GMP attributes and elements
a-h-abdelsalam
requested changes
Feb 19, 2024
a-h-abdelsalam
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds the new data type Report Config and the corresponding GMP commands create_report_config, delete_report_config, get_report_configs and modify_report_config.
Why
This will later allow configuring the parameters of predefined report formats when exporting reports or setting up alerts.
References
GEA-416