Fix: Fix modify config preference, set pref_... fields in cleanup-config-prefs #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
When modifying a config, the database fields containing the VT id, preference id, type and name are now set for all types. This fixes the preferences not working correctly after modifying them.
The --optimize option cleanup-config-prefs now also sets the fields pref_nvt, pref_id, pref_type, pref_name if they are missing or invalid for VT preferences or sets them to NULL for scanner preferences.
a-h-abdelsalam
force-pushed
the
fix-modify-config-preference
branch
from
ff81467 to
097a880
Compare
a-h-abdelsalam
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When modifying a config, the database fields containing the
VT id, preference id, type and name are now set for all types.
The --optimize option cleanup-config-prefs now also sets the fields
pref_nvt, pref_id, pref_type, pref_name if they are missing or invalid
for VT preferences or sets them to NULL for scanner preferences.
Why
This fixes the preferences not working correctly after modifying them.
References
GEA-450