Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostnames to report data for templates #854

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

timopollmeier
Copy link
Member

What

The main hostnames and a list of all hostnames are added to each host
and scan results now also have their associated hostname added.

Why

This allows adding the hostname info to generated reports.

References

GEA-378

Checklist

  • Tests

The internal variable "hostname" of the scan report transformation is
renamed to "host_ip" to later avoid confusion with the actual hostname.
@timopollmeier timopollmeier requested a review from a team as a code owner November 28, 2023 15:20
@greenbonebot greenbonebot enabled auto-merge (rebase) November 28, 2023 15:20
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@9afd2b8). Click here to learn what that means.

Files Patch % Lines
pheme/transformation/scanreport/gvmd.py 87.17% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage        ?   88.55%           
=======================================
  Files           ?       35           
  Lines           ?     1363           
  Branches        ?        0           
=======================================
  Hits            ?     1207           
  Misses          ?      156           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The main hostnames and a list of all hostnames are added to each host
and scan results now also have their associated hostname added.

This allows adding the hostname info to generated reports.
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

auto-merge was automatically disabled November 29, 2023 06:46

Rebase failed

@timopollmeier timopollmeier merged commit 4ad4afc into main Nov 29, 2023
17 checks passed
@timopollmeier timopollmeier deleted the add-hostnames branch November 29, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants