Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE api MAX_CVES_PER_PAGE to 2k #925

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

mbrinkhoff
Copy link
Member

What

Adjusts the MAX_CVES_PER_PAGE value 2000 as per the updated (?) docs.

Why

The current 10000 value auto-breaks implementing tools.

References

Closes: https://jira.greenbone.net/browse/DEVOPS-862

Checklist

  • Tests

@mbrinkhoff mbrinkhoff requested a review from a team as a code owner November 13, 2023 13:34
@greenbonebot greenbonebot enabled auto-merge (rebase) November 13, 2023 13:34
@mbrinkhoff mbrinkhoff added the make release To trigger GitHub release action. label Nov 13, 2023
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #925 (7c3786c) into main (fd0e4cb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          97       97           
  Lines        6782     6782           
  Branches      976      976           
=======================================
  Hits         6130     6130           
  Misses        446      446           
  Partials      206      206           
Files Coverage Δ
pontos/nvd/cve/api.py 95.09% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@greenbonebot greenbonebot merged commit 74e0fa4 into main Nov 13, 2023
21 checks passed
@greenbonebot greenbonebot deleted the fix_cve_api_page_limit branch November 13, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants