Change: Shrink the signature of all Model classes #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Remove the static model creation methods `_get_value` and `_get_value_from_model_field_cls` from the Model class and refactor them to functions. This methods are just used during model creation and afterwards should not be available on the Model instance.
bjoernricks
force-pushed
the
model-improvements
branch
from
ab790c5 to
e1ea02c
Compare
y0urself
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the static model creation methods
_get_valueand_get_value_from_model_field_clsfrom the Model class and refactor them to functions.Why
This methods are just used during model creation and afterwards should not be available on the Model instance.