Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrEnum #930

Merged
merged 4 commits into from
Nov 17, 2023
Merged

StrEnum #930

merged 4 commits into from
Nov 17, 2023

Conversation

bjoernricks
Copy link
Contributor

What

Add a StrEnum class until we can use the one from the standard library.

Why

For easier usage of enum values in models provide an StrEnum class.

Checklist

  • Tests

Copy link

github-actions bot commented Nov 16, 2023

Conventional Commits Report

Type Number
Changed 3
Added 1

🚀 Conventional commits found.

Allow to use a Enum class with str behavior for easier usage of models
with enum values in APIs.
This enum already used the same pattern as our new StrEnum class.
@bjoernricks bjoernricks marked this pull request as ready for review November 17, 2023 07:32
@bjoernricks bjoernricks requested a review from a team as a code owner November 17, 2023 07:32
@bjoernricks bjoernricks enabled auto-merge (rebase) November 17, 2023 07:32
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1d96b0) 90.38% compared to head (07f4d86) 90.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   90.38%   90.37%   -0.02%     
==========================================
  Files          97       97              
  Lines        6784     6776       -8     
  Branches      976      976              
==========================================
- Hits         6132     6124       -8     
  Misses        446      446              
  Partials      206      206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjoernricks bjoernricks merged commit a4df543 into main Nov 17, 2023
@bjoernricks bjoernricks deleted the strenum branch November 17, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants